Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=480235 Rex Dieter <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #1 from Rex Dieter <[email protected]> 2009-01-15 15:23:48 EDT --- initial comments from quick perusal: 1. use BR: kdelibs4-devel instead of kdelibs-devel (to avoid ambiguity) 2. omit -DCMAKE_INSTALL_PREFIX=$(kde4-config --prefix) -DCMAKE_BUILD_TYPE=debugfull not required or desired, %_cmake_kde4 macro includes both already 3. what's -DKDE4_BUILD_TESTS:BOOL=${BUILD_TESTS} for? I don't see BUILD_TESTS defined anywhere. ? 4. missing icon scriptlets -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list [email protected] http://www.redhat.com/mailman/listinfo/fedora-package-review
