Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: CGAL
Alias: CGAL

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199168





------- Additional Comments From [EMAIL PROTECTED]  2006-08-17 10:15 EST -------
(Sorry for the bug spam: it seems that I have copy-pasted the whole bug 
history, in comment #19. Here is the comment as it should have been.)

Update:
  Spec URL: http://www.di.ens.fr/~rineau/Fedora/CGAL-3.2.1-15.fc5.src.rpm
  SRPM URL: http://www.di.ens.fr/~rineau/Fedora/CGAL.spec

%changelog
* Thu Aug 17 2006 Laurent Rineau 
<[EMAIL PROTECTED]> - 3.2.1-15
- Change the permissions of /etc/profile.d/cgal.*sh
- Remove the meta package CGAL. CGAL-libs is renamed CGAL.
- Added two patchs:
  - CGAL-3.2.1-config.h-endianness_detection.patch which is an upstream patch
    to fix the endianness detection, so that is is no longer hard-coded in
    <CGAL/compiler_config.h>,
  - CGAL-3.2.1-install_cgal-no_versions_in_compiler_config.h.patch that
    removes hard-coded versions in <CGAL/compiler_config.h>.


I have new errors from rpmlint:
  E: CGAL-devel script-without-shellbang /etc/profile.d/cgal.sh
  E: CGAL-devel non-executable-script /etc/profile.d/cgal.sh 0644
  E: CGAL-devel script-without-shellbang /etc/profile.d/cgal.csh
  E: CGAL-devel non-executable-script /etc/profile.d/cgal.csh 0644
that comes from the new permissions of those files.

And two new warnings:
  W: CGAL-devel non-conffile-in-etc /etc/profile.d/cgal.sh
  W: CGAL-devel non-conffile-in-etc /etc/profile.d/cgal.csh
that could be fixed easily.

To summarize, the issues that remains:
(In reply to comment #8)
> Further issues:
> 
> - The *-devel package ships /usr/include/CORE
> IMO, this directory name is too general.
> 
> - Static libs:
> /usr/lib/libCGALQt.a
> /usr/lib/libcore++.a

These two issue last. And I do not see how to deal with that (especially 
the /usr/include/CORE issue, which cannot be fixed without changing CORE 
documentation and uses).


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

Reply via email to