Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

--- Comment #19 from Michal Hlavinka <>  2009-01-20 10:44:23 
EDT ---
first round done
rmplint squirrelmail.spec is quiet
rmplint squirrelmail-*-src.rpm is quiet

lot of not used/not useful/obsolete patches removed, some of them are not
removed from cvs repository *for now*

rpmlint noarch/squirrelmail-*-noarch.rpm is little less verbose (just a little)

> htaccess-file

moved to squirrelmail.conf

> W: wrong-file-end-of-line-encoding
>   /usr/share/doc/squirrelmail-1.4.17/ReleaseNotes/1.4/Notes-1.4.12.txt
> W: wrong-file-end-of-line-encoding
>   /usr/share/doc/squirrelmail-1.4.17/ReleaseNotes/1.4/Notes-1.4.13.txt

fixed with sed in spec

> E: zero-length
>  /usr/share/squirrelmail/locale/es_ES/LC_MESSAGES/

removed in spec

>  W: devel-file-in-non-devel-package
>   /usr/share/squirrelmail/plugins/filters/bulkquery/bulkquery.c
>  E: non-executable-script /usr/share/squirrelmail/plugins/demo/getpot 0644

I still haven't decided what to do with these two... (not only demo/getpot but

1) move to /usr/share/doc/squirrelmail
2) remove completely
3) move to subpackage


Tomas, if you could explain me (irc?) something about the utf-8 vs. CJK mess,
it would be really appreciated. I've got this package with some fixes for CJK
and that confuses me... I thought utf-8 should be able to handle it, so I'm
little bit confused about all CJK workarounds/patches.

Configure bugmail:
------- You are receiving this mail because: -------
You are the QA contact for the bug.

Fedora-package-review mailing list

Reply via email to