Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=480859 François Kooman <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #1 from François Kooman <[email protected]> 2009-01-21 09:38:38 EDT --- (Just some remarks from quickly looking over the package) - For your Source line see: https://fedoraproject.org/wiki/PackagingDrafts/SourceUrl, maybe also make it Source0 instead of just Source. - See https://fedoraproject.org/wiki/Packaging:Python for specific Python packaging guidelines - See https://fedoraproject.org/wiki/PackageMaintainers/CreatingPackageHowTo for a template of a spec file (or use rpmdev-newspec), it might be nice to create your spec file based on this or modify yours to better match the template. rpmlint output: [fkoo...@franek SPECS]$ rpmlint diffuse.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. [fkoo...@franek SPECS]$ [fkoo...@franek SRPMS]$ rpmlint diffuse-0.2.15-1.fc10.src.rpm diffuse.src: W: summary-not-capitalized graphical tool for comparing and merging text files diffuse.src: W: non-standard-group Development/Tools/Version Control diffuse.src: W: no-url-tag 1 packages and 0 specfiles checked; 0 errors, 3 warnings. [fkoo...@franek SRPMS]$ [fkoo...@franek noarch]$ rpmlint diffuse-0.2.15-1.fc10.noarch.rpm diffuse.noarch: W: summary-not-capitalized graphical tool for comparing and merging text files diffuse.noarch: W: non-standard-group Development/Tools/Version Control diffuse.noarch: W: no-url-tag diffuse.noarch: W: conffile-without-noreplace-flag /etc/diffuserc diffuse.noarch: E: invalid-desktopfile /usr/share/applications/diffuse.desktop 1 packages and 0 specfiles checked; 1 errors, 4 warnings. [fkoo...@franek noarch]$ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list [email protected] http://www.redhat.com/mailman/listinfo/fedora-package-review
