Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=467403


Bug 467403 depends on bug 467398, which changed state.

Bug 467398 Summary: Review Request: mingw32-gettext - GNU libraries and 
utilities for producing multi-lingual messages
https://bugzilla.redhat.com/show_bug.cgi?id=467398

           What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE



--- Comment #5 from Kevin Fenzi <ke...@tummy.com>  2009-01-21 21:22:33 EDT ---
Sorry for the delay here: 

OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name. 
OK - Spec has consistant macro usage. 
OK - Meets Packaging Guidelines. 
OK - License (LGPLv2+)
OK - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
f3e9870e213518b407a959f8d29cd554  libgpg-error-1.6.tar.bz2
f3e9870e213518b407a959f8d29cd554  libgpg-error-1.6.tar.bz2.orig
See below - BuildRequires correct
See below - Spec handles locales/find_lang
OK - Package has %defattr and permissions on files is good. 
OK - Package has a correct %clean section. 
OK - Package has correct buildroot
OK - Package is code or permissible content. 
OK - Packages %doc files don't affect runtime. 
OK - Package has rm -rf RPM_BUILD_ROOT at top of %install

MINGW32 - Headers/static libs in -devel subpackage. 
MINGW32- .pc files in -devel subpackage/requires pkgconfig
MINGW32- .so files in -devel subpackage.
MINGW32- .la files are removed. 

OK - Package compiles and builds on at least one arch. 
OK - Package has no duplicate files in %files. 
OK - Package doesn't own any directories other packages own. 
OK - Package owns all the directories it creates. 
OK - Package obey's FHS standard (except for 2 exceptions)
See below - No rpmlint output. 
OK - final provides and requires are sane.

SHOULD Items:

OK - Should build in mock. 
OK - Should build on all supported archs
OK - Should have dist tag
MINGW32 - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin,
or /usr/sbin

Issues: 

First off, this is my first mingw32 review, so I am sure I will ask some 
stupid questions...

1. For buildrequires I see in the build.log: 

checking for msgfmt...
no
checking for gmsgfmt...
:
checking for xgettext... no
checking for msgmerge... no
...
checking for GNU gettext in libc...
no

Should you add those to BuildRequires?

2. Any reason you can't use %{?_smp_mflags} with your make?
Or does that not work with mingw32 packages?

3. rpmlint of course has a bunch to say... perhaps you could get it 
to not complain when the package is mingw32-* on a lot of these?

Ignore: 

mingw32-libgpg-error.noarch: W: no-documentation
mingw32-libgpg-error.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/bin/gpg-error-config
mingw32-libgpg-error.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/include/gpg-error.h
mingw32-libgpg-error.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/lib/libgpg-error.dll.a
mingw32-libgpg-error.noarch: E: script-without-shebang
/usr/i686-pc-mingw32/sys-root/mingw/lib/libgpg-error.la
mingw32-libgpg-error.noarch: E:
arch-independent-package-contains-binary-or-object
/usr/i686-pc-mingw32/sys-root/mingw/lib/libgpg-error.dll.a
mingw32-libgpg-error.noarch: W: non-standard-dir-in-usr i686-pc-mingw32
mingw32-libgpg-error.noarch: W: spurious-executable-perm
/usr/i686-pc-mingw32/sys-root/mingw/lib/libgpg-error.dll.a

Should you be using %find_lang here: 

mingw32-libgpg-error.noarch: W: file-not-in-%lang
/usr/i686-pc-mingw32/sys-root/mingw/share/locale/de/LC_MESSAGES/libgpg-error.mo
mingw32-libgpg-error.noarch: W: file-not-in-%lang
/usr/i686-pc-mingw32/sys-root/mingw/share/locale/fr/LC_MESSAGES/libgpg-error.mo
mingw32-libgpg-error.noarch: W: file-not-in-%lang
/usr/i686-pc-mingw32/sys-root/mingw/share/locale/pl/LC_MESSAGES/libgpg-error.mo
mingw32-libgpg-error.noarch: W: file-not-in-%lang
/usr/i686-pc-mingw32/sys-root/mingw/share/locale/ro/LC_MESSAGES/libgpg-error.mo
mingw32-libgpg-error.noarch: W: file-not-in-%lang
/usr/i686-pc-mingw32/sys-root/mingw/share/locale/sv/LC_MESSAGES/libgpg-error.mo
mingw32-libgpg-error.noarch: W: file-not-in-%lang
/usr/i686-pc-mingw32/sys-root/mingw/share/locale/vi/LC_MESSAGES/libgpg-error.mo

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

Reply via email to