Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=477144 Orcan 'oget' Ogetbil <oget.fed...@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |oget.fed...@gmail.com AssignedTo|nob...@fedoraproject.org |oget.fed...@gmail.com Flag| |fedora-review? --- Comment #2 from Orcan 'oget' Ogetbil <oget.fed...@gmail.com> 2009-01-23 14:39:00 EDT --- Here's the review for this one. * The prebuilt binaries need removed in %prep ./com.cthing.cmakeed.site/plugins/com.cthing.cmakeed.core_1.0.1.jar ./com.cthing.cmakeed.site/plugins/com.cthing.cmakeed.ui_1.0.1.jar ./com.cthing.cmakeed.site/features/com.cthing.cmakeed.feature_1.0.1.jar * I believe that ./com.cthing.cmakeed.ui/doc/* should go to %doc. These don't end up in the RPM otherwise, right? * Please make the description span across 80 columns. It'll look nicer. * Macros should be used consistently. You use %{buildroot} and $RPM_BUILD_ROOT mixed. This needs corrected. You should also use %{__install} for consistency. * Please make use of the %{version} macro, e.g. in Source0 * Latest version must be packaged. Please update to 1.1.1 * There is no license file in the sources. The upstream should be notified to include a license file. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
