Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481410


Parag AN(पराग) <panem...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panem...@gmail.com
         AssignedTo|nob...@fedoraproject.org    |panem...@gmail.com
               Flag|                            |fedora-review+




--- Comment #1 from Parag AN(पराग) <panem...@gmail.com>  2009-01-24 07:39:49 
EDT ---

Review:
+ package builds in mock.
 Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1079143
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream.
27b99775072f6ad4b585f7484c47405d  Mail-POP3Client-2.18.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets are used.
+ make test gave
All tests successful.
Files=1, Tests=26,  0 wallclock secs ( 0.01 usr  0.00 sys +  0.05 cusr  0.01
csys =  0.07 CPU)

+ Package: perl-Mail-POP3Client-2.18-1.fc11 =>
Provides: perl(Mail::POP3Client) = 2.18
Requires: perl(Carp) perl(Exporter) perl(IO::Socket) perl(strict) perl(vars)
perl(warnings)

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

Reply via email to