Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-POE-Component-Server-SimpleHTTP - Serve HTTP requests in POE https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202910 [EMAIL PROTECTED] changed: What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| | ------- Additional Comments From [EMAIL PROTECTED] 2006-08-18 11:51 EST ------- This package looks fine, but I'm unsure about the long comment list of Requires: bits. It looks like those are all either found automatically by RPM or pulled in by the perl-POE dep so everything should be OK. * source files match upstream: dec01e04284b5acda6d706018b1f499c POE-Component-Server-SimpleHTTP-1.11.tar.gz * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. * license field matches the actual license. * license is open source-compatible. License text not included upstream. * latest version is being packaged. * BuildRequires are proper. * compiler flags are appropriate. * %clean is present. * package builds in mock (development, x86_64). * rpmlint is silent. * final provides and requires are sane: perl(POE::Component::Server::SimpleHTTP) = 1.11 perl(POE::Component::Server::SimpleHTTP::Connection) = 1.05 perl(POE::Component::Server::SimpleHTTP::PreFork) = 0.01 perl(POE::Component::Server::SimpleHTTP::Response) = 1.03 perl-POE-Component-Server-SimpleHTTP = 1.11-1.fc6 = perl(:MODULE_COMPAT_5.8.8) perl(Carp) perl(HTTP::Date) perl(IPC::Shareable) perl(POE) perl(POE::Component::SSLify) perl(POE::Component::Server::SimpleHTTP::Connection) perl(POE::Component::Server::SimpleHTTP::Response) perl(POE::Driver::SysRW) perl(POE::Filter::HTTPD) perl(POE::Wheel::ReadWrite) perl(POE::Wheel::SocketFactory) perl(Socket) perl(base) perl(strict) perl(warnings) * %check is present and all tests pass: All tests successful. Files=1, Tests=4, 1 wallclock secs ( 0.12 cusr + 0.05 csys = 0.17 CPU) * package is not relocatable. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedoraemail@example.com http://www.redhat.com/mailman/listinfo/fedora-package-review