Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226314





--- Comment #5 from Orcan 'oget' Ogetbil <oget.fed...@gmail.com>  2009-01-28 
11:48:53 EDT ---
Thanks for the explanation.
So I can't to do a test to evaluate the software but I could do a generic
package review since it is a simple one.
There is one minor issue and a few suggestions. Let me know whenever you update
the package so we can close the bug.

* rpmlint says
  prctl.src:22: W: setup-not-quiet
You need to use 
  %setup -q

! no disttag. I think it could be better to have a disttag to avoid
incompatibilities between the binaries produced by different versions of the
compiler. What do you think?

! The patch is trivial. I don't think it is necessary to submit upstream. It
would be nice though.

! You can make use of the %{name} macro a little more frequent

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

Reply via email to