Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=482965


Parag AN(पराग) <panem...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panem...@gmail.com
         AssignedTo|nob...@fedoraproject.org    |panem...@gmail.com
               Flag|                            |fedora-review?




--- Comment #1 from Parag AN(पराग) <panem...@gmail.com>  2009-01-28 22:38:13 
EDT ---
Review:
+ package builds in mock (rawhide i386).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1090315
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
8f9e6ba2595b07997efac1377c5484e9  XML-Generator-1.01.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=2, Tests=97,  0 wallclock secs ( 0.03 usr  0.01 sys +  0.09 cusr  0.02
csys =  0.15 CPU)
+ Package perl-XML-Generator-1.01-1.fc11 =>
  Provides:  perl(XML::Generator) = 1.01 perl(XML::Generator::cdata)
perl(XML::Generator::comment) perl(XML::Generator::final)
perl(XML::Generator::overload) perl(XML::Generator::pi)
perl(XML::Generator::pretty) perl(XML::Generator::util)
 Requires: perl(Carp) perl(base) perl(constant) perl(overload) perl(strict)
perl(vars)

Any reason for removing DOM.pm?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

Reply via email to