Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=481224 --- Comment #3 from Peter Lemenkov <[email protected]> 2009-02-02 10:39:29 EDT --- Remarks: * According to book of Black Magic, called "Packaging Guidelines", you shouldn't use tags "Vendor" and "Packager". I suggest you to remove them both. https://fedoraproject.org/wiki/Packaging/Guidelines#Tags * Please, drop condition which checks for debian. * Add "%define debug_package %{nil}" on top of your spec to disallow creating useless debuginfo sub-package (see http://cvs.fedoraproject.org/viewvc/rpms/erlang-pgsql/devel/erlang-pgsql.spec?view=markup as an example). * No need to explicitly define directory to unpack to in %prep section. I mean that "%setup" (or, better, "%setup -q") would be enough. * You're using make w/o %{?_smp_mflags} switch. Does rabbitmq-server support parallel make? If not, then you should add note (see %build section it this spec-file - http://cvs.fedoraproject.org/viewvc/rpms/ejabberd/devel/ejabberd.spec?view=markup ) I'll suggest some improvements later. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list [email protected] http://www.redhat.com/mailman/listinfo/fedora-package-review
