Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=483553 --- Comment #8 from Hans Ulrich Niedermann <rhb...@n-dimensional.de> 2009-02-02 11:42:11 EDT --- (In reply to comment #7) > General comments: > > . You shouldn't need --host parameter to configure. Removed in mingw32-libltdl-1.5.26-11.fc10 > . It would be nice if the make check rule was surrounded by > %if %{run_tests} ... %endif, and if it worked when run_tests > was enabled. (run_tests should be disabled by default though). Added in mingw32-libltdl-1.5.26-11.fc10 > ===> APPROVED > but it would be nice to see the two changes I point out at the top. Done: http://ndim.fedorapeople.org/packages/mingw32-libltdl/1.5.26-11.fc10/ http://fedorapeople.org/gitweb?p=ndim/public_git/mingw32-libltdl-package.git;a=summary Thanks for the review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
