Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Hubert Plociniczak <> changed:

           What    |Removed                     |Added
                 CC|                            |

--- Comment #2 from Hubert Plociniczak <>  2009-02-04 12:58:41 
EDT ---
I am sure Peter will follow with the proper review, but here are some bits that
I found in my informal review:

- put Requires(preun) into single line
- %{_sysconfdir}/sysconfig/couchdb instead of ${_sysconfdir}/default/couchdb
- you have 
%exclude %{_sysconfdir}/rc.d/couchdb

- use %{_initrddir} instead of %{_sysconfdir}

- init-script must not be marked as %config

- if you use %{_localstatedir} then use it consistently, for example in useradd
or sed

- use -D flag in 'install' instead of 'mkdir -p $RPM_BUILD_ROOT%{_initrddir}'
- remove 'exit 0' in %pre
- remove 'shadow-utils' since it is on ExceptionsList
- shouldn't mochiweb be a separate sub-package?
- fix the obvious rpmlint warnings, like permissions

Configure bugmail:
------- You are receiving this mail because: -------
You are on the CC list for the bug.

Fedora-package-review mailing list

Reply via email to