Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=486476 Christoph Wickert <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs? --- Comment #3 from Christoph Wickert <[email protected]> 2009-02-19 22:23:14 EDT --- (In reply to comment #2) > 1. rpmlint says: > > xfce4-power-manager.x86_64: W: non-conffile-in-etc > /etc/xdg/autostart/xfce4-power-manager.desktop > > I think this can be ignored. No one should be editing xdg autostart files > should they? No, they people cannot edit them, at least not through xfce4-autostart-editor. I'm afraid if I mark it %config the rpmnew/rpmold files could confuse the autostart. > 2. Don't include a --vendor in the desktop file install, per: > http://fedoraproject.org/wiki/Packaging/Guidelines > > Or is --vendor="" the same as no vendor? Yes, see https://fedoraproject.org/w/index.php?title=Packaging:Guidelines&oldid=49388#desktop-file-install_usage Nevertheless I'll remove it, too. Thanks for the review! New Package CVS Request ======================= Package Name: xfce4-power-manager Short Description: Power management for the Xfce desktop environment Owners: cwickert Branches: F11 (needs xfconf, so only F11 will suffice) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list [email protected] http://www.redhat.com/mailman/listinfo/fedora-package-review
