Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=486044 Remi Collet <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] AssignedTo|[email protected] |[email protected] Flag| |fedora-review? --- Comment #1 from Remi Collet <[email protected]> 2009-02-22 02:29:54 EDT --- First Notes : - As optional deps are available it should be usefull to add it Requires: php-pear(XML_Parser) php-pear(XML_Util) - I prefer the use of %{name}.xml rather than %{pear_name}.xml (see recent change to PHP Guidelines, this will avoid conflict with package from other channel) - rpmlint is silent - A comment about running test-suite will be usefull # pear run-tests -p Config Running 16 tests ... FAIL [ 3/16] test for bug 3051[/usr/share/pear/test/Config/test/bug3051.phpt] ... FAIL [16/16] regression test for bug #10185[/usr/share/pear/test/Config/test/bug10185.phpt] wrote log to "/root/run-tests.log" TOTAL TIME: 00:01 14 PASSED TESTS 0 SKIPPED TESTS 2 FAILED TESTS: /usr/share/pear/test/Config/test/bug3051.phpt /usr/share/pear/test/Config/test/bug10185.phpt Have you encounter and investigate this issue ? (at least, reported upstream) - %file must be fixed, should be %defattr(-,root,root,-) %doc %{pear_name}-%{version}/docdir/%{pear_name}/* %{pear_xmldir}/%{pear_name}.xml %{pear_testdir}/%{pear_name} %{pear_phpdir}/Config* -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list [email protected] http://www.redhat.com/mailman/listinfo/fedora-package-review
