Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=486657


Jon Levell <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]




--- Comment #5 from Jon Levell <[email protected]>  2009-02-24 16:46:54 EDT 
---
Informal review:

Looks good to me, the only quibble I would have is the make command does not
use flags to enable parallel make and there are enough source parts to warrant
using it.

http://fedoraproject.org/wiki/Packaging/Guidelines#Parallel_make

i.e. change 
make blahtexml-linux
to 
make %{?_smp_mflags} blahtexml-linux

which is faster on my system

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
[email protected]
http://www.redhat.com/mailman/listinfo/fedora-package-review

Reply via email to