Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=487263





--- Comment #1 from Parag AN(पराग) <panem...@gmail.com>  2009-02-25 01:19:03 
EDT ---
1) Good to add versioned requires

2) From http://fedoraproject.org/wiki/Packaging/SourceURL#We_are_Upstream , 
    Will you please add comment in SPEC file. Otherwise I see no way to verify
source here.

3) From review guidelines,
   SHOULD: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.

4) Though for such small package where no upstream release happened, it looks
not really needed but good to follow guidelines
http://fedoraproject.org/wiki/PackagingGuidelines#Timestamps
==> Add -p to install command

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

Reply via email to