Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=483364 Mamoru Tasaka <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #1 from Mamoru Tasaka <[email protected]> 2009-03-13 13:07:40 EDT --- Some random notes: * Licensing - First of all, from what file(s) can we judge that this software is under Artistic 2.0? * Requires/Provides - What package provides "%{name}-db"? (are the rebuilt binary rpms installable for you?) - By the way, if you make -db-{sqlite,postgresql} subpackages have "Provides: %{name}-db = %{version}", AFAIK "yum install EekBoek" will always install EekBoek and EekBoek-db-sqlite because yum usually gives higher priority to shorter name. Is this what you expect? Usually I don't recommend to add the virtual Requires on the "main" package like this (because with this yum will always choose one) and suggest to write a note which tells that admins have to install either of the packages providing database backends afterwards by themselves. * BuildRequires - "BuildRequires: glibc-common" is redundant. * Duplicate directories - Since both database backend subpackages have "Requires: %name", listing the following directories in the subpackages is not needed. Just move to the main package. --------------------------------------------------------------- %dir %{ebshare} %dir %{ebshare}/lib %dir %{ebshare}/lib/EB %dir %{ebshare}/lib/EB/DB --------------------------------------------------------------- * %changelog - As it is useful when using Fedora CVS, I recommend to put one line between %changlog entries like: --------------------------------------------------------------- %changelog * Fri Jan 30 2009 Johan Vromans <[email protected]> - 1.04.02-1 - Adapt to Fedora guidelines * Sun Jan 26 2009 Johan Vromans <[email protected]> - 1.04.02 - Remove QUICKSTART. * Sat Jul 19 2008 Johan Vromans <[email protected]> - 1.03.90 - Remove debian stuff - Don't use unstable. --------------------------------------------------------------- -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list [email protected] http://www.redhat.com/mailman/listinfo/fedora-package-review
