Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=495237 --- Comment #2 from Silas Sewell <[email protected]> 2009-04-11 14:28:44 EDT --- Thanks for the review Jussi. I added a comment to the spec regarding the sed, but in short the removed code checks to see if setuptools is installed and downloads+installs it if not. If you don't remove it the build will fail. I will send a request upstream for the license file to be included. Diff: http://code.google.com/p/silassewell/source/diff?spec=svn227&r=227&format=side&path=/trunk/projects/packages/rpms/python-hash_ring/python-hash_ring.spec SRPM: http://silassewell.googlecode.com/files/python-hash_ring-1.2-2.fc10.src.rpm rpmlint [si...@silas result]$ rpmlint python-hash_ring-1.2-2.fc10.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. [si...@silas result]$ rpmlint python-hash_ring-1.2-2.fc10.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list [email protected] http://www.redhat.com/mailman/listinfo/fedora-package-review
