Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226033





--- Comment #7 from Tom "spot" Callaway <[email protected]>  2009-04-14 
17:59:37 EDT ---
Two more things I noticed:

(1) The devel subpackage has:

Requires: %{name} = %{version}

That should be:

Requires: %{name} = %{version}-%{release}

(2) The spec is using %makeinstall, instead of make DESTDIR=$RPM_BUILD_ROOT
install. The latter works fine, so there is no good excuse not to use it.

With those two minor fixes committed to rawhide, I can close out this merge
review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.

_______________________________________________
Fedora-package-review mailing list
[email protected]
http://www.redhat.com/mailman/listinfo/fedora-package-review

Reply via email to