Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: <Cherokee> Flexible WebServer
Alias: Cherokee

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201149





------- Additional Comments From [EMAIL PROTECTED]  2006-09-02 14:35 EST -------
Which is the most recent spec and/or srpm? As a reviewer I much prefer a full
spec or srpm to download either an updated attachment or external URL. Your
comment has make CFLAGS="-O0 -g3" commented out but the attached srpm does not.
If at all possible I don't want to have to apply spec patches before reviewing.

Why do you redefine Docdir? If it is a legacy from the existing spec you should
be able to remove it.

Please make Source0 point to a URL where the tarball can be downloaded.

Build fails in %prep at the gzip line: "gzip: %SOURCE.gz: No such file or
directory" 
%setup macro makes the gzip line after it redundant anyway, the setup macro
should decompress sources. (At least it does when your source has the Source0 
tag.)



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
You are on the CC list for the bug, or are watching someone who is.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

Reply via email to