Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: autogen https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197814 ------- Additional Comments From [EMAIL PROTECTED] 2006-09-02 20:59 EST ------- A few quick notes before I start a formal review: 1. $ rpmbuild -bi autogen.spec error: bad date in %changelog: Say Aug 26 2006 Paul F. Johnson <[EMAIL PROTECTED]> 5.8.5-3 Should be "Sat", I think. After fixing that, I still can't build it: $ rpmbuild -bi autogen.spec error: Failed build dependencies: libopts-devel is needed by autogen-5.8.5-3.x86_64 # yum install libopts-devel [...] No Match for argument: libopts-devel 2. BuildRequires: guile-devel, libxml2-devel, libopts-devel libtool Please don't mix commas and spaces for separators. 3. No %{_smp_mflags} in make invocations and no comment why it should be omitted. 4. mv %{buildroot}/%{_bindir}/columns %{buildroot}/%{_bindir}/autogen.columns mv %{buildroot}/%{_bindir}/getdefs %{buildroot}/%{_bindir}/autogen.getdefs I think the convention is to use $file.$alternative-package, not $alternative-package.$file. See postfix and sendmail. 5. %description AutoGen is a tool designed to simplify the creation and maintenance of programes that contain large amounts of repetitious text. ^^^^^^^^^ Should be "programs", I think. 6. %description devel Development files for autogen Description doesn't end with a full stop. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
