Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=498246 --- Comment #4 from Jussi Lehtola <[email protected]> 2009-04-30 13:05:37 EDT --- (In reply to comment #3) > (In reply to comment #2) > > > But you don't need to be a sponsor to do reviews, just an approved packager > > (you need to be sponsorED). > It was that I meant, I am not an approved packager. Sorry. No problem. I see Mamoru is your sponsor. Reviewing packages is really important, even more so with the very long review queue we have at the moment. > > > - I think that "%doc license.gpl Examples/" is not a good thing. Because > > > Examples/ contains some executable. Install it with the doc flags modify > > > the rights. > > > > No, it is quite standard to ship executable scripts in %doc, as the program > > works without them; they're just examples of use. > > If you think people don't have to run them, I think it is good. Yes, this is the way %doc is supposed to work: extra stuff that is not mandatory for the program to run, such as manuals and examples. > > - In the file /usr/share/towhee/Forcefields, you remove Makefile but not > > > Makefile.am and Makefile.in > > > > Nope, > > find Examples/ -name "Makefile*" -exec rm {} \; > > also removes Makefile.* > > I don't talk about Examples, but about /usr/share/towhee/Forcefields. Duh, sorry, I must have misread you the first time. Removed. http://theory.physics.helsinki.fi/~jzlehtol/rpms/towhee.spec http://theory.physics.helsinki.fi/~jzlehtol/rpms/towhee-6.2.2-3.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list [email protected] http://www.redhat.com/mailman/listinfo/fedora-package-review
