Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=500476 Igor Jurišković <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #3 from Igor Jurišković <[email protected]> 2009-05-18 16:17:52 EDT --- Hello Louis. This is not official review. I'm looking for a sponsor like you. ---------------------------------------------------------------- - remove Vendor tag. Its not needed. ---------------------------------------------------------------- ---------------------------------------------------------------- - Consider using parallel make if possible. If not write in comment above make why not. https://fedoraproject.org/wiki/Packaging/Guidelines#Parallel_make ---------------------------------------------------------------- ---------------------------------------------------------------- - install doesn't preserve timestamps. Add INSTALL="install -p" like: make DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" install http://fedoraproject.org/wiki/How_to_create_an_RPM_package#.25install_section ---------------------------------------------------------------- ---------------------------------------------------------------- - update package to new version. ---------------------------------------------------------------- ---------------------------------------------------------------- - I'm unable to download source but are you sure that License is only GPL? If possible be more specific like GPLv3+... ---------------------------------------------------------------- ---------------------------------------------------------------- - %doc part can go into one line. Its easier to read but its your choice. ---------------------------------------------------------------- ---------------------------------------------------------------- - you need to make space between changelogs: * Thu Mar 12 2009 Louis Lagendijk <[email protected]> - something * Thu Feb 19 2009 Louis Lagendijk <[email protected]> - something * ... ---------------------------------------------------------------- - you're missing "-" at the beginning of some changes. ---------------------------------------------------------------- ---------------------------------------------------------------- - changelog part is missing version and release number: * Thu Mar 12 2009 Louis Lagendijk <[email protected]> <version>-<release> ---------------------------------------------------------------- -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list [email protected] http://www.redhat.com/mailman/listinfo/fedora-package-review
