Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=483434





--- Comment #12 from Jussi Lehtola <[email protected]>  2009-05-22 12:43:20 
EDT ---
Also:

- Remove the heading space from the description

- Refer to argtable2 instead of libargtable2 in the devel package.

- You probably don't need to use --docdir in the %configure phase. After
install, you should move the documentation back into the build directory, e.g.
 mv %{buildroot}%{_defaultdocdir}/%{name}-devel-%{version} docdir
and include the documentation with
 %doc docdir/*
Also, as the documentation is large, you should branch it to a package of its
own as Michael suggested.

(Also, I'm not very fond of using macros for rm, make and so on.)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
[email protected]
http://www.redhat.com/mailman/listinfo/fedora-package-review

Reply via email to