Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478922


Orcan 'oget' Ogetbil <oget.fed...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |oget.fed...@gmail.com
         AssignedTo|nob...@fedoraproject.org    |oget.fed...@gmail.com
               Flag|                            |fedora-review+

Bug 478922 depends on bug 467237, which changed state.

Bug 467237 Summary: Review Request: globus-gssapi-gsi - Globus Toolkit - GSSAPI 
library
https://bugzilla.redhat.com/show_bug.cgi?id=467237

           What    |Old Value                   |New Value
----------------------------------------------------------------------------
         Resolution|                            |NEXTRELEASE
             Status|ASSIGNED                    |CLOSED

Bug 478922 depends on bug 467239, which changed state.

Bug 467239 Summary: Review Request: globus-gss-assist - Globus Toolkit - GSSAPI 
Assist library
https://bugzilla.redhat.com/show_bug.cgi?id=467239

           What    |Old Value                   |New Value
----------------------------------------------------------------------------
         Resolution|                            |NEXTRELEASE
             Status|ASSIGNED                    |CLOSED



--- Comment #3 from Orcan 'oget' Ogetbil <oget.fed...@gmail.com>  2009-05-30 
16:37:14 EDT ---
I reviewed this package and found one minor issue

- koji rawhide build is fine
   http://koji.fedoraproject.org/koji/taskinfo?taskID=1385107

* These type of warnings may indicate misbehavior in 64bit systems
   warning: format '%d' expects type 'int', but argument 4 has type
'globus_size_t'
Can you patch this up? Swapping %d with %zd will probably solve the issue.

- rpmlint
   globus-ftp-control-devel.x86_64: W: no-documentation
can be ignored

Otherwise, the package is good to go. Please take care of the above warnings
before you commit.

-----------------------------------------------------
This package (globus-ftp-control) is APPROVED by oget
-----------------------------------------------------

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

Reply via email to