Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kshutdown - KShutDown is an advanced shut down utility for KDE. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203789 [EMAIL PROTECTED] changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED] OtherBugsDependingO|163776 |163779 nThis| | ------- Additional Comments From [EMAIL PROTECTED] 2006-09-09 21:22 EST ------- OK - Package name OK - Spec file matches base package name. OK - Meets Packaging Guidelines. OK - License (GPL) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 6acd45acc5c0669b0973f0246e4bcca7 kshutdown-0.8.2.tar.bz2 6acd45acc5c0669b0973f0246e4bcca7 kshutdown-0.8.2.tar.bz2.1 OK - Package compiles and builds on at least one arch. OK - BuildRequires correct OK - Spec handles locales/find_lang OK - Package owns all the directories it creates. OK - Package has no duplicate files in %files. OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Spec has consistant macro usage. OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - .la files are removed. OK - Package is a GUI app and has a .desktop file OK - Package doesn't own any directories other packages own. OK - No rpmlint output. SHOULD Items: OK - Should include License or ask upstream to include it. OK - Should build in mock. Issues: 1. Should look at using a %{?dist} tag. See: http://www.fedoraproject.org/wiki/Packaging/DistTag Thats the only issue I see with this package, so it's APPROVED. Please remember to close this bug with NEXTRELEASE once it has been imported and built. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list [email protected] http://www.redhat.com/mailman/listinfo/fedora-package-review
