Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: koan https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192313 [EMAIL PROTECTED] changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED] OtherBugsDependingO|163776 |163778 nThis| | ------- Additional Comments From [EMAIL PROTECTED] 2006-09-15 11:14 EST ------- Two small comments: * Don't define the %name macro manually, setting 'Name:' will do that for you * The way you define INSTALLED_FILES leads to /usr/lib/python2.4/site-packages/koan/ and subdirs to not be owned by koan and sticking around after an uninstall. The %files section should read something like %files %defattr(-,root,root) %{_bindir}/koan /usr/lib/python?.?/site-packages/koan %{_mandir}/man1/koan.1.gz * Just as a suggestion that won't block this package: since you are upstream for this, you should include a copy of the GPL in COPYING, and %doc it in the specfile -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
