Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=511938


Mike Bonnet <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #12 from Mike Bonnet <[email protected]>  2009-07-17 15:02:41 EDT ---
Looks good, I think you're all set.  One minor issue, %{?dist} is generally not
included in the %changelog because it gets expanded there too, and can cause
unusual/nonsense NVRs to appear in the changelog across distro upgrades.

I'm approving this review.  Please follow the rest of the steps in the new
package process, and let me know if you have any issues.  Don't forget to file
the FE-ExcludeArch bugs for ppc and ppc64.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
[email protected]
http://www.redhat.com/mailman/listinfo/fedora-package-review

Reply via email to