Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=513345 --- Comment #3 from Jan F. Chadima <[email protected]> 2009-07-23 07:34:10 EDT --- > > - You seem to create TMPFILE rather early and later have to delete it if one > of > the error conditions are met. At least one rm seem to be missing there, so > may > be easier to create it later when you're really going to need it. > done > - You can save few extra commands / redirections by doing changes like: > > grep something file > /dev/null --> grep -q something file I do not like extra switches if not necessary > cat file | wc -l --> wc -l file This is not the same (try it :) > > - This should have a README with big warning sysadmins should not to be > tempted > to use this as root as: > May be, but the sysadmins will do it anyhow. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list [email protected] http://www.redhat.com/mailman/listinfo/fedora-package-review
