Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=493246 --- Comment #25 from Jan Klepek <[email protected]> 2009-07-27 10:02:46 EDT --- looks ok, last small things... 1] shutter.src: W: mixed-use-of-spaces-and-tabs (spaces: line 2, tab: line 12) > > 2] in %install you are creating directory named "0755" in bin/ and share/ > > Are there any problems? I think it is OK for us. > When i think about it, you probably want to do something else by following commands: install -d -p 0755 $RPM_BUILD_ROOT%{_bindir} install -d -p 0755 $RPM_BUILD_ROOT%{_datadir} cp -fr -p 0755 bin/* $RPM_BUILD_ROOT%{_bindir}/ cp -rf -p 0755 share/* $RPM_BUILD_ROOT%{_datadir}/ if you want to set permissions, you have to use switch -m (for install, cp doesn't allow this as far as I know) from this POV i don't think that spec file is legible (incorrectly used commands) I'm sorry for lag between my answers/replies, work takes more time nowadays -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list [email protected] http://www.redhat.com/mailman/listinfo/fedora-package-review
