Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=512726 Stepan Kasal <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |[email protected] AssignedTo|[email protected] |[email protected] Flag| |fedora-review? --- Comment #1 from Stepan Kasal <[email protected]> 2009-07-31 10:46:54 EDT --- OK source files match upstream, sha1sum: c943efd0c268e812fa9ed6176ea1630e3de17c86 Test-Refcount-0.05.tar.gz OK package meets naming and versioning guidelines. FAIL specfile is properly named, is cleanly written and uses macros consistently. %files should contain "%{perl_vendorlib}/Test" to avoid packing the auto subdir. You might also want to use %{_mandir}/man3/Test*.3* OK dist tag is present. OK build root is correct. OK license field matches the actual license. OK license is open source-compatible. OK license text included in package. OK latest version is being packaged. FAIL BuildRequires are proper. add: perl(Test::More) perl(Test::Pod) OK compiler flags are appropriate. OK %clean is present. OK package builds in mock. OK package installs properly. OK no debuginfo package OK rpmlint is silent. OK final provides and requires are sane: FAIL %check is present and all tests pass. The test suite fails. The reason is probably a bug in Devel::FindRef, I filed it as https://rt.cpan.org/Ticket/Display.html?id=48357 Add a comment mentioning this, including the link to the bug. OK no shared libraries are added to the regular linker search paths. OK owns the directories it creates. OK doesn't own any directories it shouldn't. OK no duplicates in %files. FAIL file permissions are appropriate. - the manpage and *.pm is read only, this is unusual - consider calling "%{_fixperms} $RPM_BUILD_ROOT/*" OK no scriptlets present. OK code, not content. OK documentation is small, so no -docs subpackage is necessary. OK %docs are not necessary for the proper functioning of the package. OK no headers, pkgconfig files, libtool .la droppings, nor desktop files Nicolas, please fix the above issues. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list [email protected] http://www.redhat.com/mailman/listinfo/fedora-package-review
