Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=485638 Jussi Lehtola <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #17 from Jussi Lehtola <[email protected]> 2009-08-14 08:02:49 EDT --- I don't agree. I think keeping the BuildRoot stuff doesn't hurt anything: it's just a few lines, and it avoids using conditionals that are a lot easier to get wrong. Having one and only spec file for the different branches is a plus, also. ** - The %description line fits on two lines. No need to use four. - Any reason why you are not using SMP make? If it doesn't work, please document it. - Your patch doesn't have a comment. Add one explaining what it does and why it is necessary. - I think you are missing a Requires: on the package that provides the font dmenu uses. ** I am a sponsor, so I can sponsor you if necessary. You just need to do a few informal reviews first. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list [email protected] http://www.redhat.com/mailman/listinfo/fedora-package-review
