Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: SDL_pango - Rendering of internationalized text for SDL https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=207676 ------- Additional Comments From [EMAIL PROTECTED] 2006-09-26 10:54 EST ------- Well, I will do a full review for this package. 1. From http://fedoraproject.org/wiki/Packaging/Guidelines : * rpmlint - rpmlint is not silent. ----------------------------------------------------------- W: SDL_Pango wrong-file-end-of-line-encoding /usr/share/doc/SDL_Pango-0.1.2/README W: SDL_Pango wrong-file-end-of-line-encoding /usr/share/doc/SDL_Pango-0.1.2/AUTHORS W: SDL_Pango wrong-file-end-of-line-encoding /usr/share/doc/SDL_Pango-0.1.2/ChangeLog W: SDL_Pango wrong-file-end-of-line-encoding /usr/share/doc/SDL_Pango-0.1.2/NEWS W: SDL_Pango-devel wrong-file-end-of-line-encoding /usr/share/doc/SDL_Pango-devel-0.1.2/globals_enum.html W: SDL_Pango-devel wrong-file-end-of-line-encoding /usr/share/doc/SDL_Pango-devel-0.1.2/globals_eval.html W: SDL_Pango-devel wrong-file-end-of-line-encoding /usr/share/doc/SDL_Pango-devel-0.1.2/index.html W: SDL_Pango-devel wrong-file-end-of-line-encoding /usr/share/doc/SDL_Pango-devel-0.1.2/annotated.html W: SDL_Pango-devel wrong-file-end-of-line-encoding /usr/share/doc/SDL_Pango-devel-0.1.2/globals.html W: SDL_Pango-devel wrong-file-end-of-line-encoding /usr/share/doc/SDL_Pango-devel-0.1.2/globals_vars.html W: SDL_Pango-devel wrong-file-end-of-line-encoding /usr/share/doc/SDL_Pango-devel-0.1.2/dir_000003.html W: SDL_Pango-devel wrong-file-end-of-line-encoding /usr/share/doc/SDL_Pango-devel-0.1.2/struct___s_d_l_pango___matrix.html W: SDL_Pango-devel wrong-file-end-of-line-encoding /usr/share/doc/SDL_Pango-devel-0.1.2/dir_000002.html W: SDL_Pango-devel wrong-file-end-of-line-encoding /usr/share/doc/SDL_Pango-devel-0.1.2/_s_d_l___pango_8h.html W: SDL_Pango-devel wrong-file-end-of-line-encoding /usr/share/doc/SDL_Pango-devel-0.1.2/doxygen.css W: SDL_Pango-devel wrong-file-end-of-line-encoding /usr/share/doc/SDL_Pango-devel-0.1.2/files.html W: SDL_Pango-devel wrong-file-end-of-line-encoding /usr/share/doc/SDL_Pango-devel-0.1.2/globals_type.html W: SDL_Pango-devel wrong-file-end-of-line-encoding /usr/share/doc/SDL_Pango-devel-0.1.2/globals_func.html W: SDL_Pango-devel wrong-file-end-of-line-encoding /usr/share/doc/SDL_Pango-devel-0.1.2/dir_000000.html W: SDL_Pango-devel wrong-file-end-of-line-encoding /usr/share/doc/SDL_Pango-devel-0.1.2/struct___s_d_l_pango___matrix-members.html W: SDL_Pango-devel wrong-file-end-of-line-encoding /usr/share/doc/SDL_Pango-devel-0.1.2/_s_d_l___pango_8h-source.html W: SDL_Pango-devel wrong-file-end-of-line-encoding /usr/share/doc/SDL_Pango-devel-0.1.2/dir_000004.html W: SDL_Pango-devel wrong-file-end-of-line-encoding /usr/share/doc/SDL_Pango-devel-0.1.2/_s_d_l___pango_8c.html W: SDL_Pango-devel wrong-file-end-of-line-encoding /usr/share/doc/SDL_Pango-devel-0.1.2/dir_000001.html ----------------------------------------------------------- This is because these files have Windows-type end-of-file encoding. You should modify this by: ----------------------------------------------------------- set +x for f in `find . -type f` ; do if file $f | grep -q CRLF ; then echo "Fixing the encoding of $f" sed -i -e 's|\r||g' $f fi done set -x ----------------------------------------------------------- at the final of %prep. * Build root tag - Any reason not to change this to %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) ? Adding %(%{__id_u} -n) ensures that different users use different buildroots for rebuilding rpms. Well, however if you don't like this for some reason, let me know (I won't force this and this is not a blocker). 2. From http://fedoraproject.org/wiki/Packaging/ReviewGuidelines : = Nothing. 3. Other things I have noticed: * Well, SDL_Pango-devel-0.1.2-2.fc6/usr/share/doc/SDL_Pango-devel-0.1.2/doxygen.png is CORRUPTED!! I think this file should be removed for this version and you can report this to upstream. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list [email protected] http://www.redhat.com/mailman/listinfo/fedora-package-review
