Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=522394





--- Comment #1 from Andrew Overholt <[email protected]>  2009-09-10 10:22:43 
EDT ---
X please add a comment for the patch (the patch itself seems fine)
X license seems to be ASL 2.0 for the plugin but parts contained (some .js
files) are GPL v2 and GPL v2+.  Please reflect this in the license field.
X please add your real name to the changelog

- naming fine
- builds fine
- %files fine
- macros fine
- Requires good
- sources match upstream
- rpmlint fine:

$ rpmlint
/home/overholt/rpmbuild/SRPMS/maven-plugin-cobertura-2.3-2.fc11.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

$ rpmlint
/home/overholt/rpmbuild/RPMS/noarch/maven-plugin-cobertura-2.3-2.fc11.noarch.rpm
maven-plugin-cobertura.noarch: W: no-documentation
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

$ rpmlint
/home/overholt/rpmbuild/RPMS/noarch/maven-plugin-cobertura-javadoc-2.3-2.fc11.noarch.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
[email protected]
http://www.redhat.com/mailman/listinfo/fedora-package-review

Reply via email to