Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=518017


Remi Collet <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #3 from Remi Collet <[email protected]>  2009-09-11 10:15:26 
EDT ---
REVIEW:

:) rpmlint is silent
php-pecl-sphinx.src: I: checking
php-pecl-sphinx.x86_64: I: checking
php-pecl-sphinx-debuginfo.x86_64: I: checking
3 packages and 1 specfiles checked; 0 errors, 0 warnings.
:) package name
:) spec file name
:) package must meet the Packaging Guidelines (PHP, ...)
:) license approved (PHP)
:) license match upstream
:) no license bundled by upstream
:) specfile legible, english, UTF8
:) sources math upstream
d5bd7c00a8e036d7f82e98ebb0d9b210  sphinx-1.0.0.tgz
:) build on F-11 x86_64 against PHP 5.3.1RC1
:) build on mock (F-11 i386)
:) BR ok
:) no locale
:) no shared lib (php extension are not "real" shared lib)
:) own all directories that it creates
:) perms ok
:) %clean section
:) consistently use macros
:) contain code
:) no large doc
:) run without %doc
:) no -devel, .pc needed
:) no GUI
:) not own files or directories already owned by other packages
:) %install, with rm -rf
:) extension (un)registration ok (pecl list)
:) final Requires
/usr/bin/pecl 
libsphinxclient-0.0.1.so()(64bit)
php(api) = 20090626
php(zend-abi) = 20090626
:) final provides
php-pecl(sphinx) = 1.0.0
sphinx.so()(64bit)  
php-pecl-sphinx = 1.0.0-2.fc8
php-pecl-sphinx(x86-64) = 1.0.0-2.fc8


So : APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
[email protected]
http://www.redhat.com/mailman/listinfo/fedora-package-review

Reply via email to