Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=517858 --- Comment #12 from Mamoru Tasaka <[email protected]> 2009-09-12 11:52:00 EDT --- For -6: * %_docdir - Again I see this line: ----------------------------------------------------------- 35 mkdir -p $RPM_BUILD_ROOT%{_docdir}/%{name} ----------------------------------------------------------- * Some more cleanup ----------------------------------------------------------- 24 %setup -qn %{name}-%{version} ----------------------------------------------------------- - This can be simplified as "%setup -q" because the default directory of %setup is "%{name}-%{version}" ----------------------------------------------------------- 39 cp -a ../%{name}-%{version}/* $RPM_BUILD_ROOT%{_datadir}/%{name} ----------------------------------------------------------- - This can be simplified as ----------------------------------------------------------- cp -a * $RPM_BUILD_ROOT%{_datadir}/%{name} ----------------------------------------------------------- because at this stage the working directory is %{_builddir}/%{name}-%{version} * About quickinstall.sh - Maybe it is good to check the id (of this script) in this script because at least this script needs the previledge to write to /usr/share/RackTables/inc/secret.php . -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list [email protected] http://www.redhat.com/mailman/listinfo/fedora-package-review
