Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=524888 --- Comment #1 from Gianluca Sforna <[email protected]> 2009-09-27 18:27:42 EDT --- SPEC looks good, just some remarks: * You should refine the steps needed to create the tarball, the tar command is not correct and I had to do a "cvs login" before the "cvs checkout". this is correctly explained in https://vecmath.dev.java.net/servlets/ProjectSource. * I can't match the md5sum of the tarball, that's probably becasue xz is still a bit in "flux" or you used some options. If the former, please consider using the regular gz compression. I diffed the sources and thay match though. * please consider adding the "cvs" string the release field, it looks like a "SHOULD" in https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Snapshot_packages but often explicit is better than implicit. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list [email protected] http://www.redhat.com/mailman/listinfo/fedora-package-review
