Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=526041 Christoph Wickert <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #8 from Christoph Wickert <[email protected]> 2009-09-29 06:23:41 EDT --- A few more comments: - %description should end with a dot - use %global instead of %define https://fedoraproject.org/wiki/PackagingDrafts/global_preferred_over_define - license is completely unclear: Is this GPLv2 or GPLv2+? How about a COPYING file or license headers in the files? - any reason not to use %defattr(-,root,root,-) as we usually do? Not that it really matters... - timestamps don't match: Source0 in the srpm is 28. Sep 15:27, while the one from the url is 15:33. Timestamps should match, see https://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps /me knows he is pedantic, but we must not ship this until at least the license question is answered. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list [email protected] http://www.redhat.com/mailman/listinfo/fedora-package-review
