Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=520663 Jussi Lehtola <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #7 from Jussi Lehtola <[email protected]> 2009-10-02 19:22:36 EDT --- (In reply to comment #6) > Also, your -devel package currently Requires: %{name} = %{version}-%{release}, > but the main package is not actually generated (because it contains no files). > You'd want to remove that requirement. And modify it for -doc, to require the > -devel subpackage instead. This bit is actually slightly incorrect (or malformed): the main package isn't generated since it does not have a %files section. However, had you put in an empty %files section, e.g. %files then the main package would be generated, even though it doesn't contain any files. ** Instead of %exclude %{_libdir}/*.la you can just run run rm -f %{_libdir}/*.la at the end of %install, which IMHO is a cleaner solution. ** %{__chmod} 0644 tests/lib/account-manager.py should be in %prep, shouldn't it? ** I think you are missing Requires: telepathy-filesystem in the -devel package for dir ownership. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list [email protected] http://www.redhat.com/mailman/listinfo/fedora-package-review
