Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=526115





--- Comment #1 from Rex Dieter <[email protected]>  2009-10-12 13:20:55 EDT 
---
A few comments:

1.  can drop extranenous
BuildRequires: qt-devel

2.  drop
Requires: qtcurve-kde4...
(agreed on irc)

3.  description:
allowing users to achieve a uniform look between three widget toolkits.
"three"?  maybe meant to say "these"  here. ?

4.  %post/%postun scriplets not needed

5.  %files , instead use:
%{_libdir}/gtk-2.0/*/engines/libqtcurve.so
%{_datadir}/themes/QtCurve/

no need for _kde4 macros here, and to own QtCurve/ dir

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
[email protected]
http://www.redhat.com/mailman/listinfo/fedora-package-review

Reply via email to