Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=528841


Toshio Ernie Kuratomi <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[email protected]
         AssignedTo|[email protected]    |[email protected]
               Flag|                            |fedora-review+




--- Comment #3 from Toshio Ernie Kuratomi <[email protected]>  2009-10-14 
13:37:40 EDT ---
Using the new srpm here:
http://fedorapeople.org/~nb/review/sks-1.1.1-2.fc11.src.rpm

Good:                                                         
* Package named appropriately.  Upstream tarball and binary are sks.
* Licensed GPLv2+, sources confirm
* license file included in package
* Spec file is legible
* Source matches upstream
* No locale files
* Not a library package
* No bundled libraries
* Not relocatable
* All created directories are owned and no others.
* Proper %clean
* macros used consistently
* Code, not content
* No %doc files affect the package runtime
* Not a GUI application
* All filenames are utf-8
* Package builds forall arches in koji
* rpmlint clean
* C libraries are dynamically linked
* Files have good permissions

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
[email protected]
http://www.redhat.com/mailman/listinfo/fedora-package-review

Reply via email to