Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=530374 Ionuț Arțăriși <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #1 from Ionuț Arțăriși <[email protected]> 2009-10-23 16:41:33 EDT --- Hi! I'm not a packager and so I can't approve your package yet. Just trying to help with some tips. License: License of the code seems to be GPLv2, not GPLv2+. The license of the icons is a CC by-nc-nd which is unnacceptable for fedora: https://fedoraproject.org/wiki/Licensing#Bad_Licenses_3 Missing BuildRequires(checked for by configure script): pkgconfig, gettext Check out: https://fedoraproject.org/wiki/PackagingDrafts/ScriptletSnippets#GTK.2B_icon_cache for updating the icon cache. This package could probably use a .desktop file, too. It already has the icons. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list [email protected] http://www.redhat.com/mailman/listinfo/fedora-package-review
