Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=532276


Thomas Spura <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]




--- Comment #1 from Thomas Spura <[email protected]>  2009-11-01 
07:26:28 EDT ---
Just a few comments:

- Can you remove the first unneed comment line?
  in %build the comment is also unneeded and CFLAGS="$RPM_OPT_FLAGS" can be
removed

- When installed, there are 2 directories owed by googlevoice:
100K /usr/lib/python2.6/site-packages/googlevoice/
776K /usr/share/doc/python-googlevoice-0.4

Could you split the doc into a subpackage, because if you just want to install
the python files and no examples/documentation, you can save 88.6% with 2 extra
packages.
Possibly, that's why there are 2 sources, the normal tar.gz and the
*-extras.zip.
Upstream also wants to save space ;)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
[email protected]
http://www.redhat.com/mailman/listinfo/fedora-package-review

Reply via email to