Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=530198


Mamoru Tasaka <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|[email protected]    |[email protected]
               Flag|                            |fedora-review?




--- Comment #1 from Mamoru Tasaka <[email protected]>  2009-11-02 
11:57:47 EDT ---
Some notes:

* %check
  - Please add %check section as this package contains test/
    directory

* License
  - Well, while I believe this is under GPLv2+, "README" says
    this is under GPLv2, so it is safer that the license tag
    is changed to GPLv2.

* %define -> %global
  - We now prefer to use %global rather than %define.

* unused macro
  - The defined macro %ruby_sitelib does not seem to be used.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
[email protected]
http://www.redhat.com/mailman/listinfo/fedora-package-review

Reply via email to