Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: wmctrl - A command line tool to interact with an EWMH/NetWM compatible X Window Manager. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=208422 [EMAIL PROTECTED] changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED] OtherBugsDependingO|163776 |163778 nThis| | ------- Additional Comments From [EMAIL PROTECTED] 2006-10-04 15:46 EST ------- It seems approvable for me. I have a comment, though which isn't a blocker. You used wildcards in %files, it is fine and sometimes unavoidable, but I myself prefer listing a bit more explicitely, to notice when something change in the package. It is a matter of personal preferences, but I would have chosed, in your case, something along: %{_bindir}/wmctrl %{_mandir}/man1/wmctrl.1* Now you have to find a sponsor. This package is a bit simple but you shown you were able to follow the guidelines. I am ready to sponsor you if conky is accepted, but since it is a much more complicated package, I'll also sponsor you if you do usefull comments on other reviews. That's the first time I am in a position to sponsor somebody so I hope I'll be good sponsor ;-) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list [email protected] http://www.redhat.com/mailman/listinfo/fedora-package-review
