Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: alsa-oss - Userspace OSS emulation https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=209144 ------- Additional Comments From [EMAIL PROTECTED] 2006-10-05 15:41 EST ------- Jima, a first list of issues before I do a more formal review: - tarball is 1.0.12 but Version field is 1.0.11 :-) As you know we want 1.0.12 since we have to match the version of alsa-lib that's in FC6. While fixing that, you can also remove the prever macro and rc3 release tags, as well as the '-n' option on the %prep command ? - Requires: /sbin/ldconfig not necessary when ldconfig called with -p option - Nit pick: there's a tradition of puting the package version in the patch file, as well a a short tag to describe it (aka foo-1.0.2-fixthis.patch) - Can you remove the commented-out autoreconf ? Comments are not welcomed within scriplets. - I don't think the CFLAGS= is necessary on the configure line, but you may want to double check. - configure needs --disable-static (and *.a removed from %files) - .la files need to be removed (from %files also) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list [email protected] http://www.redhat.com/mailman/listinfo/fedora-package-review
