Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=537587





--- Comment #23 from Rahul Sundaram <[email protected]>  2009-11-18 23:15:32 
EDT ---

According to packaging guidelines:

"The Vendor tag should not be used. It is set automatically by the build
system"

If you build only for Fedora, you can drop

"Buildroot:              %{_tmppath}/%{name}-%{version}-root"

and after the %install line, drop

"[ "$RPM_BUILD_ROOT" != "/" ] && %{__rm} -rf $RPM_BUILD_ROOT"

after the %clean line, change to

%{__rm} -rf $RPM_BUILD_ROOT

!=/ check is unnecessary. RPM takes care of that.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
[email protected]
http://www.redhat.com/mailman/listinfo/fedora-package-review

Reply via email to