Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226423 --- Comment #8 from Michal Hlavinka <[email protected]> 2009-11-25 11:12:12 EDT --- (In reply to comment #7) > > BuildRequires: /usr/bin/aclocal > > Should be better automake. > fixed > > Source0: > > http://prdownloads.sourceforge.net/%{name}/%{name}-%{version}.snap20091119.tar.gz > > I don't see such file there. Just keep the filename part. > https://fedoraproject.org/wiki/Packaging/SourceURL#Using_Revision_Control fixed > > Version: 5.38 > > Release: 24.20091119svn%{?dist} > > [...] > > %setup -q -n %{name}-5.39 > > Shouldn't we have "Version: 5.39" + "Release: 0.20091119svn%{?dist}", since > the > tarball's version is "5.39"? I'd rather call it 5.39 pre-release than 5.38 > release bump. 5.39 in setup section is there because smartmontools package is created by "make dist" and (as usual) upstream bumbs version in autotools config files just after releasing any new version. I think it's better to use snapshot versioning as specified in: https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ Fedora-package-review mailing list [email protected] http://www.redhat.com/mailman/listinfo/fedora-package-review
