Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: tenr.de-styles-pkg - A collection of over 200 styles/themes for fluxbox https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=209959 [EMAIL PROTECTED] changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[EMAIL PROTECTED] ------- Additional Comments From [EMAIL PROTECTED] 2006-10-09 07:14 EST ------- * There shouldn't be a '.' in the package name as seen here: http://fedoraproject.org/wiki/Packaging/NamingGuidelines * The rpmlint issue is ignorable, although you may want to open a bug about missing Creative Commons licences. * If I'm not wrong -r is impled by -a for cp. * The Source0 should be an url. It seems to be http://www.tenr.de/files/fluxmod-styles-pkg.tar.bz2 What is a bit bad is that there is no versionning, you should certainly ask upstream for a version string (in ascii ascending order...). Since there doesn't seems to be any release number currently, and if upstream don't want to add any, my advice would be to use the stamp file to construct the version. Something along: %define stamp 20061009 Version: 0.%{stamp} Source0: %{name}-%{stamp}.tar.bz2 # unversioned upstream source, downloaded with wget -N # renamed to %%{name}-YYYYMMDD.tar.gz #Source0: http://www.tenr.de/files/tenr.de-styles-pkg.tar.bz2 %setup -q -n %{name} With $ ls -l tenr.de-styles-pkg.tar.bz2 -rw-r--r-- 1 dumas dumas 4778973 Oct 9 00:05 tenr.de-styles-pkg.tar.bz2 The leading 0 in version is there to try to have future version number higher. * %{_styledir}/ will be unowned. * The most annoying thing is that it doesn't work out of the box, the new themes don't appear anywhere in the fluxbox menu... -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list [email protected] http://www.redhat.com/mailman/listinfo/fedora-package-review
